Skip to content

common: replace Rational typedef to a new class #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

common: replace Rational typedef to a new class #119

wants to merge 1 commit into from

Conversation

cchampet
Copy link
Member

  • Issue in bindings with a typedef of a class defined by FFmpeg.
  • Solution: create a class which is a wrapper of AVRational.
  • Update pyTest which use Rational.

common: replace Rational typedef to a new class
fb41156 
* Issue in bindings with a typedef of a class defined by FFmpeg.
* Solution: create a class which is a wrapper of AVRational.
* Update pyTest which use Rational.
@cchampet
Copy link
Member Author

I can't tell Swig to include AVRational (an FFmpeg struct) in its binding.
So our typedef in AvTranscoder (typedef AVRational Rational) works but gives us a Swig_object without methods we want.

@cchampet
Copy link
Member Author

See #122

@cchampet cchampet closed this Oct 27, 2014
@cchampet cchampet deleted the fix_binding_ratio branch October 28, 2014 10:13
cchampet added a commit to cchampet/avTranscoder that referenced this pull request Mar 16, 2015
@cchampet
Merge pull request avTranscoder#119 from cchampet/fix_audioTransformW…
3c71de0 
…henNbSamplesChange

Fix AudioTransform:  when nbSamples change between frames (MOV)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchampet @fabiencastan @MarcAntoine-Arnaud