-
Notifications
You must be signed in to change notification settings - Fork 50
Add feature: set frame #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cchampet
commented
Oct 31, 2014
- Also available for bindings.
- Clean.
* Do not duplicate getters with AudioFrameDesc (getSampleRate, getChannels...). * Keep symmetry with VideoCodec (rename getFrameDesc to getAudioFrameDesc).
Remove comments.
Add OptionArray and OptionMap.
* Easier to manipulate complexe data (in AvTranscoder and in other libraries...). * Remove forward declaration of 'Option': need to include 'Context' to get 'OptionArray' typedef.
* Test NULL pointer to avoid possible crash. * Do not skip format name with no video track possible.
Remove assert which are already tested before calling init (private) function.
We delete all the 'StreamTranscoder' in destructor of 'Transcoder': can't add a reference to a stream from outside like this.
…Index Symmetry with other processTranscode method.
* An external library could need to update a specific stream during process. * Also add a getter to the current Essence in StreamTranscoder, for the same reason above.
* 2 tests in the python file: * Generate a video stream, and set its frame during process. * Generate a audio stream, and set its frame during process. * Swig: add template to have access to DataBuffer methods in bindings. * IInputEssence: add virtual method setFrame. Reasons: * avoid cast when setFrame. * can access this feature whithout issue in bindings. * it could be a case to set some frames of a stream which is from an input file (still not implemented).
* The functions returns duration of last packet added. * Not what we expected, and not used.
* The method setOutputFps does not do what the user expected: the fps of Transcoder is only used for progress bar (no consequencies in transcode process !). * This kind of method must be implemented in the outputStream on which we want to update the fps.
This private function decodes the next frame (call avcodec_decode_audio4).
* Return false as status of decoding if size of frame is 0.
Symmetry with AvInputAudio: add private function decodeNextFrame.
Get Video / Audio FrameDesc from a frameDesc instead of a link to a codec.
Skip the first one which was an undefined codec in the enum list.
* Manage memory of StreamTranscoder by spliting streams into 2 vectors. * Add pyTest "testTranscoderAdd" to test if we correctly manage memory.
Get only one instruction "new".
Use make_pair.
* To manage cases with generators: a user can overload his Generator and create a StreamTranscoder. * Update testSetFrame.py
PyTests which use GeneratorAudio failed after the last commit. I don't no why... |
On mac it will be correct. |
The Travis MAC OS jobs work because they do not launch pyTest.
|
…into dev_setFrame Conflicts: src/AvTranscoder/transcoder/StreamTranscoder.hpp src/AvTranscoder/transcoder/Transcoder.cpp src/AvTranscoder/transcoder/Transcoder.hpp
…into dev_setFrame Conflicts: src/AvTranscoder/transcoder/Transcoder.cpp src/AvTranscoder/transcoder/Transcoder.hpp
cchampet
pushed a commit
to cchampet/avTranscoder
that referenced
this pull request
Mar 13, 2015
* Can install doc by using: 'make install doc'. * Note: the doc is not generate by the default target ('all'). * Fix avTranscoder#124
cchampet
pushed a commit
to cchampet/avTranscoder
that referenced
this pull request
Mar 17, 2015
* Can install doc by using: 'make install doc'. * Note: the doc is not generate by the default target ('all'). * Fix avTranscoder#124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.