-
Notifications
You must be signed in to change notification settings - Fork 50
AudioReader: can specify the channel index #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cchampet
merged 48 commits into
avTranscoder:develop
from
cchampet:dev_audioReaderChannelIndex
Jan 19, 2016
Merged
AudioReader: can specify the channel index #186
cchampet
merged 48 commits into
avTranscoder:develop
from
cchampet:dev_audioReaderChannelIndex
Jan 19, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the next frame when decode
* The constructors are easier to call. * By default we explicitly copy the input parameters (width, height, pixelFormat) to the output.
Added 'output' when the element concerns output.
* The constructors are easier to call. * By default we explicitly copy the input parameters (sampleRate, nbChannels) to the output.
Added 'output' when the element concerns output.
* Just need to get the properties. * See next commit.
Indicate that these are 'source' properties.
* Added const to local variables when it's possible. * Renamed several local variables.
… specified channel does not exist
Previously debug.
No need to call updateOutput AudioReader::method when specify a channelIndex in constructor.
7d4b3d1
to
95c4bec
Compare
…into dev_audioReaderChannelIndex
95c4bec
to
f918ef3
Compare
…into dev_audioReaderChannelIndex
…SamplesPerChannel
* CodedData: describes coded data. * Frame: describes decoded (raw) audio or video data. * Need to use AVFrame instead of AVPacket in avtranscoder Frame class.
* Create decoded/coded folders to split classes in data directory. * Video/AudioFrameDesc are struct with puclic access to their attributes. * Sorry for this huge commit, but it is hard to split it.
* Not used. * AudioGenerator: removed _frameDesc attributes and the methods to manipulate it.
Renamed to inherit the setNextFrame method in based class.
"cannot allocate an array of constant size 0".
* Not tested. * Not used. * Can be done by accessing the full buffer thanks to getData method.
cchampet
added a commit
that referenced
this pull request
Jan 19, 2016
AudioReader: can specify the channel index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.