-
Notifications
You must be signed in to change notification settings - Fork 50
Video/Audio decoding: fix decoding if the reading process failed #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be possible to have no more data to read from the input, but to have data stored in the decoder.
Since all our generators are allocated, and their FrameDesc are set just after.
Since all our generators are allocated, and their FrameDesc are set just after.
…oders * If we want to call the generator, no need to call decodeNextFrame on the other decoder each time. This commit avoids this. * This is the same solution in StreamTranscoder class.
* No need to define them, since _inputFrame, _blackImage/_silent are not copied. * With this update, _frameDesc can be a const attribute.
@@ -23,6 +23,9 @@ class AvExport IDecoder | |||
/** | |||
* @brief Decode next frame | |||
* @param frameBuffer: the frame decoded | |||
* @warn the frameBuffer reference belongs to the decoder and is valid only until the | |||
* next call to this function or until closing or flushing the | |||
* decoder. The caller may not write to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caller may not write into it.
valnoel
pushed a commit
to valnoel/avTranscoder
that referenced
this pull request
Jul 22, 2016
…onMessage Clean log and exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.