Skip to content

Video/Audio decoding: fix decoding if the reading process failed #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 14, 2016

Conversation

cchampet
Copy link
Member

@cchampet cchampet commented Apr 7, 2016

No description provided.

Clement Champetier added 2 commits April 7, 2016 17:41
It could be possible to have no more data to read from the input,
but to have data stored in the decoder.
…oders

* If we want to call the generator, no need to call decodeNextFrame on
the other decoder each time. This commit avoids this.
* This is the same solution in StreamTranscoder class.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.758% when pulling 2ff4b51 on cchampet:fix_decoding into 550e1ff on avTranscoder:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 74.31% when pulling 34fef16 on cchampet:fix_decoding into 550e1ff on avTranscoder:develop.

* No need to define them, since _inputFrame, _blackImage/_silent are not
copied.
* With this update, _frameDesc can be a const attribute.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 74.661% when pulling fd3be2c on cchampet:fix_decoding into 550e1ff on avTranscoder:develop.

@@ -23,6 +23,9 @@ class AvExport IDecoder
/**
* @brief Decode next frame
* @param frameBuffer: the frame decoded
* @warn the frameBuffer reference belongs to the decoder and is valid only until the
* next call to this function or until closing or flushing the
* decoder. The caller may not write to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller may not write into it.

@valnoel valnoel merged commit 236ebe0 into avTranscoder:develop Apr 14, 2016
valnoel pushed a commit to valnoel/avTranscoder that referenced this pull request Jul 22, 2016
…onMessage

Clean log and exception message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants