Skip to content

VideoProperties: fix decoding of first frames #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cchampet
Copy link
Member

@cchampet cchampet commented May 3, 2016

No description provided.

Clement Champetier added 16 commits May 3, 2016 14:04
* Use Frame class instead (allocation/free is managed by the class).
Use VideoProperties::getProfile() method.
Use Frame::getEncodedSize() method.
* Use VideoProperties::getGopSize() instead.
* Add doc to this method.
* To get the level of analysis asked inside member methods.
* Will be used in the next commit.
* AVCodecContext->gop_size is unused when decode according to the ffmpeg
documentation:
https://ffmpeg.org/doxygen/2.8/structAVCodecContext.html#a9b6b3f1fcbdcc2ad9f4dbb4370496e38
* So compute this info when analyseGopStructure, and store it inside the
VideoProperties class.
* Because the gop size could be used inside getBitRate() method, throw a
runtime exception before using it.
* Before: picture type, is key frame
* After: picture type, encoded frame size in bytes
* Note: "is key frame" info can be found using the picture type (I
frame).
Throw a runtime_error if the duration is unknown.
…rties

* These instructions make analysis impossible for some AVC Intra media.
* WARNING: need to check if this commit induces some side effects.
The C++ structure was updated in commit:
81bc92e
@cchampet cchampet changed the title VideoPproperties: fix decoding of first frames VideoProperties: fix decoding of first frames May 3, 2016
@@ -48,7 +48,7 @@ std::string VideoProperties::getProfileName() const
throw std::runtime_error("unknown codec profile");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use getProfile() as well just up here !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better here: 4df7cc4

Clement Champetier added 3 commits May 13, 2016 10:20
Avoid RuntimeError: basic_string::_S_construct null not valid.
Need to analyse first GOP to compute bitrate and get gop size of output.
@cchampet
Copy link
Member Author

cchampet commented May 13, 2016

Too many updates. See PR #247 and #248

@cchampet cchampet closed this May 13, 2016
valnoel added a commit to valnoel/avTranscoder that referenced this pull request Jul 22, 2016
…SwAvResample_2

CMake: fix double dependencies of av/sw resample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants