Skip to content

Conversation

cchampet
Copy link
Member

Do not print them with other properties, since:

  • they are very specific options.
  • not all of them can be printed.
  • we can access them with getter methods (getCodecOptions).

Clement Champetier added 3 commits May 25, 2016 15:37
Do not print them with other properties, since:
* they are very specific options.
* not all of them can be printed.
* we can access them with getter methods (getCodecOptions).
* Images are considered as video streams with one frame by ffmpeg.
* We cannot compute a gop size as a distance between two I frames.
* So we set the gop size by iteration.
We could analyse first gop and don't retreive the gop size (in case of a
decoding error).
@cchampet cchampet force-pushed the dev_propertiesGetCodecPrivateOptions branch from 5df34b5 to 2890f5b Compare May 25, 2016 13:41
@coveralls
Copy link

coveralls commented May 25, 2016

Coverage Status

Coverage decreased (-0.08%) to 74.479% when pulling 2890f5b on cchampet:dev_propertiesGetCodecPrivateOptions into 4574951 on avTranscoder:develop.

@coveralls
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage decreased (-0.08%) to 74.479% when pulling 34859e3 on cchampet:dev_propertiesGetCodecPrivateOptions into 7ed9558 on avTranscoder:develop.

@valnoel valnoel merged commit 31a3f01 into avTranscoder:develop May 26, 2016
valnoel pushed a commit to valnoel/avTranscoder that referenced this pull request Jul 22, 2016
…pAudio

OutputFile: fix AVCodecContext of stream when addAudioStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants