Patches to make integration of avTranscoder into other software easier #251
Conversation
This patch adds AvTranscoderConfig.cmake and FindAvTranscoder.cmake which can be used by the external software to link against avTranscoder libraries.
Some containers, e.g. Matroska, requires the headers be written in the global headers section, not in each packet. The encoder should be notified, if that is the case.
|
Hello! |
|
Sure! I'll write open an issue if I cannot fix it within Krita itself :) The biggest limitation I have right now is that avTranscoder has no Ubuntu package, neither in official repositories, nor in ppa. But I think it is solvable... |
| @@ -42,6 +42,16 @@ IOutputStream& OutputFile::addVideoStream(const VideoCodec& videoDesc) | |||
| stream.codec->level = videoDesc.getAVCodecContext().level; | |||
| stream.codec->field_order = videoDesc.getAVCodecContext().field_order; | |||
|
|
|||
| if (_formatContext.getAVOutputFormat().flags & AVFMT_GLOBALHEADER) { | |||
| stream.codec->flags = CODEC_FLAG_GLOBAL_HEADER; | |||
There was a problem hiding this comment.
Because the flags attribute could have a value before this assignement, I think it's better to do:
stream.codec->flags |= CODEC_FLAG_GLOBAL_HEADER;
Don't you think?
There was a problem hiding this comment.
Good point. I though that videoDesc.getAVCodec() returns a codec with empty flags.
…InCode CMake: get AvTranscoder versions from headers
Hi!
I'm trying to integrate avTranscoder into Krita project. I need it to be able to save the hand-painted animation into various animation formats. My main target formats are mkv, mp4, ogg and gif.
Here are the two patches I had to do to make integration of avTranscoder easier into other applications. One creates necessary cmake modules. The other one fixes a small bug when working with the .mkv format.