Analyse raw video stream #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 20, 2016 16:14
Define only const methods.
…te stream properties With the FileProperties class, we have access to several conveniant methods.
If it is a raw stream, get the file size to compute the stream duration.
Use class methods instead of manipulate the FFmpeg classes.
added 7 commits
June 21, 2016 11:57
Avoid 'Arithmetic exception'.
The local variable 'bitsPerByte' is not necessary.
* Get or compute the stream bitrate depending on the stream type. * VideoProperties: no need to override getDuration method.
…methods Instead of a 'global' seek in FileProperties.
af72019 to
5e6e05a
Compare
added 2 commits
June 21, 2016 12:08
* We cannot access properties of the returned object since the local InputFile of the method is deleted (scope of the method). * Is not used and not tested.
added 5 commits
June 21, 2016 15:14
* Check value of format long name. * Check value of mimeType set by ffmpeg.
Need to indicate the 'h264' format.
* Use the PropertyVector to add as many metadata as needed. * Better coverage of the code when launch this test :)
Depending on how ffmpeg/libav is built, the format long name could be empty. The tests should pass in this case.
18 similar comments
| const AVMediaType streamType = getStreamType(); | ||
|
|
||
| // compute audio bitrate | ||
| if(streamType == AVMEDIA_TYPE_AUDIO) |
There was a problem hiding this comment.
This switch could be avoided making StreamProperties virtual, overridden by VideoProperties and AudioProperties, don't you think?
added 4 commits
June 22, 2016 16:00
* Revert of commit 1804369. * * VideoProperties: need to override getDuration method (so StreamProperties::getDuration is virtual).
…se GOP Throw an exception when the first GOP has not been analysed.
No need to analyse first GOP.
…r any deep analysis
cdc7c4b to
39ebb6c
Compare
valnoel
added a commit
to valnoel/avTranscoder
that referenced
this pull request
Jul 22, 2016
…ioStreamChannelLayout OutputFile: copy channel_layout for each audio stream added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #253