Skip to content

OutputStream: set global header flag if required + enable experimental codecs #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2016
Merged

OutputStream: set global header flag if required + enable experimental codecs #255

merged 3 commits into from
Jun 23, 2016

Conversation

cchampet
Copy link
Member

No description provided.

dimula73 and others added 2 commits June 21, 2016 17:33
@dimula73
Set the global header flag if the container format requires it
0c88502 
Some containers, e.g. Matroska, requires the headers be written
in the global headers section, not in each packet. The encoder
should be notified, if that is the case.
OutputFile: updated how to set the codec 'flags' when addVideoStream
b40674d 
Because the flags attribute could have a value before this assignement.
@cchampet cchampet mentioned this pull request Jun 21, 2016
Closed
@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 74.457% when pulling b40674d on cchampet:fix_outputVideoCodecFlags into bd420a5 on avTranscoder:develop.

@cchampet
Copy link
Member Author

cchampet commented Jun 22, 2016 •
edited
Loading

This PR removes the ffmpeg/libav warning when create a media with a video stream:

 Codec for stream 0 does not use global headers but container format requires global headers

Could be removed for the audio too?
Fixed with this commit: e96c7b6

OutputFile: added private method setOutputStream
e96c7b6 
* This method is called for each video/audio output streams.
* It sets general parameters of the stream, depending on the
format/codec.
@coveralls
Copy link

coveralls commented Jun 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 74.487% when pulling e96c7b6 on cchampet:fix_outputVideoCodecFlags into bd420a5 on avTranscoder:develop.

@cchampet cchampet changed the title Fix output video codec flags OutputStream: set global header flag if required + enable experimental codecs Jun 23, 2016
@cchampet cchampet merged commit 8ddf8e1 into avTranscoder:develop Jun 23, 2016
valnoel pushed a commit to valnoel/avTranscoder that referenced this pull request Jul 22, 2016
log: add private attribute to set header of logs only once
b59b050 
Fix avTranscoder#255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchampet @coveralls @dimula73