-
Notifications
You must be signed in to change notification settings - Fork 50
Transcoder: can extract several channels from an input stream, and encode them to one output stream #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcoder: can extract several channels from an input stream, and encode them to one output stream #269
Conversation
…rated streams Warning: the profile should define information to instanciate the codec: * for video: width, height, pixel format * for audio: sampleRate, nbChannels, sample format.
Will cause conflicts in the next commit (refactoring).
* Now we are using the codec properties defined in the given profile. * Next step: remove re-encoding process and directly wrap the generated data.
* This struct is given as parameter to the 'add' method of the Transcoder. * Updated python tests.
…dStream' * Removed private method 'addGeneratedStream' (no more needed). * Updated python tests.
* Updated their doc. * Updated python tests.
* According to some ffmpeg code, there is no need to allocate a buffer of 1024 characters to store the channel layout name. * See https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/tests/formats.c#L28
Will be used in the next commit.
* Handle a vector of channel index instead of a single index (with -1 to get all of them).
Conflicts: src/AvTranscoder/transcoder/StreamTranscoder.cpp
This is the common case of the audio decoding.
…into dev_transcoderRewrapToMultiChannels Conflicts: test/pyTest/testEProcessMethod.py
Added a local variable.
…t cannot * Updated doc of the method. * Added a python test.
To get all inputStreamDesc instead of only the array of channel index.
@@ -163,7 +163,7 @@ class AvExport Transcoder | |||
void addTranscodeStream(const InputStreamDesc& inputStreamDesc, | |||
const ProfileLoader::Profile& profile, const float offset = 0); | |||
|
|||
void addDummyStream(const ProfileLoader::Profile& profile); | |||
void addGeneratedStream(const ProfileLoader::Profile& profile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but once more, I am discussing the name of a method: here at first reading, it seems addGeneratedStream means you "add a stream that has already been generated", while you would like to "add a stream that will be generated by the transcoder". So I'd prefer something like addStreamGeneration, addStreamToGenerated or addStreamGenerator, which seems clearer to me. Don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of the vote: "addGenerateStream".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See commit 584f530
* Removed ffmpeg dependent testRewrapVideoPositiveOffsetWithoutGenerator * The RuntimeError raising is not systematic
Fix #265
Fix #151