Fix filter graph memory leak #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought it was done each time here ; If this does not work, this intruction should be removed... In which case you saw a memory leak ? |
| @@ -550,6 +550,10 @@ bool StreamTranscoder::processTranscode() | |||
| LOG_DEBUG("Convert") | |||
| _transform->convert(*_filteredData, *_transformedData); | |||
|
|
|||
| // free the filtered AVFrame now it has been converted into another one | |||
There was a problem hiding this comment.
Could you add a warning in the doc of the FilterGraph::process method about that ?
added 2 commits
July 26, 2016 14:03
…irectly the av_frame_unref function And removes redundant documentation
|
Actually, this code is only executed if there is no filter to apply. The problem is that we have to free the AVFrame each time we apply the filter graph. Without this clear, the memory usage grows all along the process until it is completely full. This appears on processing long medias (muxing audio channels extracted from movies, for instance). |
|
Ok great ! So this code at is not necessary. Could you remove it, and after that this PR is ready to be meged i think :) |
|
Yes, actually this code is necessary if no filter has been added to the FilterGraph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time we use the av_buffersink_get_frame function, we have to free the output AVFrame.
See the av_buffersink_get_frame documentation.