VideoProperties: improve how to analyse the first GOP #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cchampet merged 11 commits into avTranscoder:develop from cchampet:refactor_VideoPropertiesAnalyseFirstGOP

Nov 4, 2016

Member

cchampet commented Nov 2, 2016

Analyse the first GOP only once instead of twice!

Clement Champetier added 7 commits

November 2, 2016 17:29


          VideoProperties: skip GOP decoding to estimate the bitrate when analy…

efccced

…sing only the header


          VideoProperties: refactor how to estimate the video bitrate

* The first GOP is already decoded once, in analyseGopStructure private
method.
* Use the results already computed to estimate the bitrate.


          VideoProperties: throw a runtime if the GOP size is invalid when deco…

8e63e7f

…ding

So no need to check this attribute in other method.


          VideoProperties: refactor analyseGOPStructure method

163a02a

Return immediatly at the beginning of the function if some attributes
are not correctly set.


          FileProperties: update how to construct the properties

42f78c9

* Keep a reference to the InputFile.
* This new reference will be used to refactor the decoding in case of
deep analysis.


          VideoProperties: refactor how to analyse the GOP structure

acd25dc

Use the avtranscoder objects: easier to maintain.


          VideoProperties: remove setting of skip_frame when analysing the firs…

ba6b391

…t GOP

cchampet assigned valnoel

cchampet added the 2 - Working label


          pyTest: fix file analysis of raw format (eAnalyseLevelFirstGop)

dfc2c98

coveralls commented Nov 3, 2016 •

edited

Loading

Coverage increased (+0.3%) to 77.174% when pulling dfc2c98 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.

1 similar comment

coveralls commented Nov 3, 2016 •

edited

Loading

Coverage increased (+0.3%) to 77.174% when pulling dfc2c98 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.

valnoel reviewed

View reviewed changes

src/AvTranscoder/properties/VideoProperties.cpp

-                  LOG_WARN("The bitrate of the stream '" << _streamIndex << "' of file '" << _formatContext->filename << "' is unknown.")
+                  if(_levelAnalysis == eAnalyseLevelHeader)
+                  {
+                      LOG_WARN("The bitrate of the stream '" << _streamIndex << "' of file '" << _formatContext->filename << "' is unknown.")

Member

valnoel Nov 3, 2016

Maybe we could add a message that says something like "Enable first GOP analyze to extract the bitrate value"?

Member Author

cchampet Nov 3, 2016

Yes you are right! 14120ec


          VideoProperties: update log when bitRate is not available in the cont…

462b50d

…ainer

cchampet force-pushed the refactor_VideoPropertiesAnalyseFirstGOP branch from 14120ec to 462b50d Compare

November 3, 2016 13:14


          Merge branch 'develop' of https://github.com/avTranscoder/avTranscoder …

60dc19c

…into refactor_VideoPropertiesAnalyseFirstGOP

Conflicts:
	src/AvTranscoder/properties/VideoProperties.cpp

coveralls commented Nov 3, 2016 •

edited

Loading

Coverage increased (+0.3%) to 77.174% when pulling 462b50d on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.

3 similar comments

coveralls commented Nov 3, 2016

Coverage increased (+0.3%) to 77.174% when pulling 462b50d on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.

coveralls commented Nov 3, 2016

Coverage increased (+0.3%) to 77.174% when pulling 462b50d on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.

coveralls commented Nov 3, 2016

Coverage increased (+0.3%) to 77.174% when pulling 462b50d on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into 103c33f on avTranscoder:develop.


          VideoProperties: fix memory leak when analyseGopStructure

2ccf4b6

The data buffer of the VideoFrame will be allocated by the decoder.

coveralls commented Nov 3, 2016 •

edited

Loading

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

5 similar comments

coveralls commented Nov 3, 2016

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

coveralls commented Nov 3, 2016

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

coveralls commented Nov 3, 2016

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

coveralls commented Nov 3, 2016

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

coveralls commented Nov 3, 2016

Changes Unknown when pulling 2ccf4b6 on cchampet:refactor_VideoPropertiesAnalyseFirstGOP into * on avTranscoder:develop*.

cchampet merged commit 3d0dc4a into avTranscoder:develop

cchampet removed the 2 - Working label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet