CMake: remove patch version in the avtranscoder library name on Windows #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avtranscoder-0.11.0 becomes avtranscoder-0.11 * avtranscoder-java-0.11.0 becomes avtranscoder-java-0.11
71385bc to
c6744c1
Compare
1 similar comment
2 similar comments
valnoel
reviewed
Nov 7, 2016
| @@ -154,7 +154,7 @@ if(SWIG_FOUND) | |||
| # Create 'avtranscoder-java' shared lib | |||
| swig_add_module(avtranscoder-java java ${AVTRANSCODER_BINDING_FILE}) | |||
| if(WIN32) | |||
| set_target_properties(avtranscoder-java PROPERTIES OUTPUT_NAME "avtranscoder-java-${AVTRANSCODER_VERSION}") | |||
| set_target_properties(avtranscoder-java PROPERTIES OUTPUT_NAME "avtranscoder-java-${AVTRANSCODER_VERSION_MAJOR}-${AVTRANSCODER_VERSION_MINOR}") | |||
There was a problem hiding this comment.
The generated JAR name should be changed too, no?
There was a problem hiding this comment.
Arg it does not seems to be a good idea, since widely used Java tools, like Maven, expects Jar named nameJar-fullVersion.jar. We need to take some time to discuss about this possible update...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: avtranscoder is a based library for lot of other intern projects. We should be able to patch avtranscoder without recompile all our other projects based on it.