readers: use InputStreamDesc class #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cchampet merged 3 commits into avTranscoder:develop from cchampet:dev_readerUseInputStreamDesc

Jan 31, 2017

Member

cchampet commented Jan 31, 2017

Will switch to avtranscoder 0.13.0 after this PR.

Clement Champetier added 3 commits

January 31, 2017 12:29


          AudioReader: fix description of the src audio frame desc

61c4d80

If the user asks to decode only one channel in the audio stream, the src
frame should have the corresponding description (if not, the transform
that follow won't be the one expected).


          IReader: use the InputStreamDesc class to construct the readers

f77cd3e

Fix avTranscoder#297


          InputStreamDesc: add a constructor to read all the channels of the st…

2ee8330

…ream at index 0

Use it in the python tests.

cchampet assigned valnoel

cchampet added the 2 - Working label

valnoel reviewed

View reviewed changes

src/AvTranscoder/reader/AudioReader.cpp Outdated

    
                      srcFrameDesc._nbChannels = 1;

                  AudioFrameDesc srcFrameDesc = _inputFile->getStream(_inputDesc._streamIndex).getAudioCodec().getAudioFrameDesc();

                  if(! _inputDesc._channelIndexArray.empty())

                      srcFrameDesc._nbChannels = _inputDesc._channelIndexArray.size();

Member

valnoel Jan 31, 2017

👍

cchampet merged commit 6889182 into avTranscoder:develop

cchampet removed the 2 - Working label

coveralls commented Jan 31, 2017 •

edited

Loading

Coverage decreased (-0.06%) to 78.185% when pulling 2ee8330 on cchampet:dev_readerUseInputStreamDesc into dd8ae36 on avTranscoder:develop.

4 similar comments

coveralls commented Jan 31, 2017

Coverage decreased (-0.06%) to 78.185% when pulling 2ee8330 on cchampet:dev_readerUseInputStreamDesc into dd8ae36 on avTranscoder:develop.

coveralls commented Jan 31, 2017

Coverage decreased (-0.06%) to 78.185% when pulling 2ee8330 on cchampet:dev_readerUseInputStreamDesc into dd8ae36 on avTranscoder:develop.

coveralls commented Jan 31, 2017

Coverage decreased (-0.06%) to 78.185% when pulling 2ee8330 on cchampet:dev_readerUseInputStreamDesc into dd8ae36 on avTranscoder:develop.

coveralls commented Jan 31, 2017

Coverage decreased (-0.06%) to 78.185% when pulling 2ee8330 on cchampet:dev_readerUseInputStreamDesc into dd8ae36 on avTranscoder:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet