Skip to content

Fix CI : retrieving dependencies #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

valnoel
Copy link
Member

@valnoel valnoel commented Jul 26, 2017

To retrieve libogg and libvorbis from the repository

To retrieve libogg and libvorbis from the repository
Copy link
Member

@MarcAntoine-Arnaud MarcAntoine-Arnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor build is broken as wget is not installed.
Curl in installed by default on all platforms, more generic...

@valnoel
Copy link
Member Author

valnoel commented Jul 26, 2017

@MarcAntoine-Arnaud
wget is not used into AppVeyor currently, only on Travis, but it seems we have the same problem on both platform with curl, which does not complete the archives download.
wget seems to resolve the problem for Travis, but we have find another solution for AppVeyor... (so I switch this PR in WIP) :)

Thanks for the review, by the way. ;)

@valnoel valnoel changed the title Fix CI : retrieving dependencies [WIP] Fix CI : retrieving dependencies Jul 26, 2017
@MarcAntoine-Arnaud
Copy link
Member

Okay, it seems AppVeyor was already broken before your PR.
I think we need to fix AppVeyor build before merge it.

@valnoel
Copy link
Member Author

valnoel commented Jul 26, 2017

OK, actually for AppVeyor, the problem does not seems to come from curl but from the URL to FFmpeg, that return a 404 Not Found status. Indeed, there is no more ffmpeg-2.4.5-win32-dev.7z into the repository. Do you have any idea of where we could find a new repository?

On Travis we could keep curl using a -L option, and piping the response into a file :

$ curl -OL http://downloads.xiph.org/releases/vorbis/libvorbis-1.3.4.tar.gz > libvorbis-1.3.4.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   460  100   460    0     0   1429      0 --:--:-- --:--:-- --:--:--  1428
100   442  100   442    0     0     42      0  0:00:10  0:00:10 --:--:--   891
100 1593k  100 1593k    0     0   133k      0  0:00:11  0:00:11 --:--:-- 1962k

@MarcAntoine-Arnaud Would it be better according to you ?

@MarcAntoine-Arnaud
Copy link
Member

This PR is okay for me, I think we can merge instead of AppVeyor build still broken.

To fix AppVeyor, it means we need to support FFMpeg > 3.0 (#252)

@valnoel
Copy link
Member Author

valnoel commented Jul 26, 2017

OK then! I cannot find any another repository with FFmpeg Windows builds... I create a new issue for this: #302
@cchampet OK for you?

@valnoel valnoel changed the title [WIP] Fix CI : retrieving dependencies Fix CI : retrieving dependencies Jul 26, 2017
@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage remained the same at 78.185% when pulling f5e3fe0 on valnoel:fix_ci_getDependencies into 858cc2f on avTranscoder:develop.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.185% when pulling f5e3fe0 on valnoel:fix_ci_getDependencies into 858cc2f on avTranscoder:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.185% when pulling f5e3fe0 on valnoel:fix_ci_getDependencies into 858cc2f on avTranscoder:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.185% when pulling f5e3fe0 on valnoel:fix_ci_getDependencies into 858cc2f on avTranscoder:develop.

@cchampet
Copy link
Member

Thank you gentlemen ;)
Indeed, to fix AppVeyor, we will have to to support FFMpeg > 3.0...

@cchampet cchampet merged commit 236454a into avTranscoder:develop Jul 27, 2017
Copy link
Member

@cchampet cchampet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants