-
Notifications
You must be signed in to change notification settings - Fork 50
Fix: different frame size as inputs of the filter graph #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2dc9d24
FilterGraph: push input frames into the filter buffer
80017d6
FilterGraph: add new internal FrameBuffer class
cb8ae5d
FilterGraph: use FrameBuffers for each filter graph input
3864d7e
FilterGraph: improve input frame size computing
053f9be
FilterGraph: frame buffers can be bypassed if not necessary
380f238
FilterGraph: minor clean into FrameBuffer class
27cf448
FilterGraph: refactoring of getMinInputFrameSize() private method
82382fc
StreamTranscoder: flush filter graph buffers after decoding process
cbd4700
StreamTranscoder: reset frame that has not been decoded
06b8b45
FilterGraph: renames FrameBuffer to AudioFrameBuffer
969c6c3
FilterGraph: remove useless areInputAudioFrames() method
c823ad6
FilterGraph: fix AudioFrameBuffer class name case typo
d2a7f54
FilterGraph: fix AudioFrameBuffers order
2dcdc1c
FilterGraph: fix audio frames management with different sample formats
343ef4e
Test: add a new python test for audio channels muxing
a26bae9
FilterGraph: fixes Python binding compilation on Windows
9abcb90
Test: check output files duration directly through file properties
0e49751
StreamTranscoder: avoid checking every filter graph buffer if the pro…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this type mean that the supported data type is only 1byte per sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is actually the raw data in bytes, without considering the sample format or whatever.