Muxing silent audio channels #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

valnoel merged 8 commits into avTranscoder:develop from valnoel:muxing_silent_audio_channels

Sep 28, 2017

Member

valnoel commented Sep 21, 2017 •

edited

Loading

The idea of this PR is to enable muxing of generated streams into a multichannel output stream.
To indicate we want to generate such a channel, we can now create one or more InputStreamDesc with empty filename, and add it to the input sources of a Transcoder. A generator will be used as channel source.
However, we cannot generate an output stream will only generated channels with this method, since we can use Transcoder::addGenerateStream() method with the corresponding output profile.
But for instance, we can now create a 5.1 audio stream with a silent LFE channel.

Valentin NOEL added 7 commits

September 21, 2017 14:52


          StreamTranscoder: add null input stream to generate output channel

55a4bab

If the InputStreamDesc filename is empty, a generator is set up as input


          StreamTranscoder: manage process case according to the input index

dd89b56


          Transcoder: handle empty filnames only case

4d4ca1e


          StreamTranscoder: store the index of the first non-null input stream

28dc5fe

Instead of using the getFirstInputStreamIndex() private method.


          StreamTranscoder: throw an exception if no non-null InputStream is se…

a85f867

…t as input

User should use the StreamTranscoder(IOutputFile&, const
ProfileLoader::Profile&) constructor to handle this case.


          Transcoder: throw an exception if no non-empty filename is set as input

cc755ba

Since the input profile cannot be guessed from such inputs.


          Tests: add silent audio channels muxing tests

c609ac8

coveralls commented Sep 21, 2017

Coverage decreased (-0.02%) to 78.661% when pulling c609ac8 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

1 similar comment

coveralls commented Sep 21, 2017 •

edited

Loading

Coverage decreased (-0.02%) to 78.661% when pulling c609ac8 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.


          InputStreamDesc: add a few documentation

d834fe3

valnoel changed the title ~~[WIP] Muxing silent audio channels~~ Muxing silent audio channels

valnoel assigned cchampet

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

6 similar comments

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

coveralls commented Sep 22, 2017

Coverage decreased (-0.02%) to 78.661% when pulling d834fe3 on valnoel:muxing_silent_audio_channels into d33ffd2 on avTranscoder:develop.

Member Author

valnoel commented Sep 25, 2017

@cchampet Could you review this PR?

valnoel merged commit 647e3de into avTranscoder:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet