-
Notifications
You must be signed in to change notification settings - Fork 50
Refactoring & minor updates #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcAntoine-Arnaud
merged 15 commits into
avTranscoder:master
from
cchampet:dev_subStreams
Jul 25, 2014
Merged
Refactoring & minor updates #32
MarcAntoine-Arnaud
merged 15 commits into
avTranscoder:master
from
cchampet:dev_subStreams
Jul 25, 2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cchampet
commented
Jul 25, 2014
- InputAudio: raise exception if selected subStream doesn't exist.
- Profile audio: sample rate and channel is not required.
- VideoFrame / AudioFrame: can setParameters from a profile.
- AudioFrameDesc: can setSampleFormat from sample format name.
- AudioDesc: can setAudioParameters from an audioFrameDesc.
Update avTranscoder swig file.
* Instead of setPixel. * Suppress comments.
* If a subStream is selected, set channels of the frameDesc used to instanciate _sourceBuffer. * Add todo.
If no sample rate is indicated in the profile, the output file will have the same sample rate as the input file.
If no number of channel is indicated in the profile, the output file will have the same number of channels as the input file.
Rename the file.
If the subStream doesn't exist, raise an exception.
Rename nbChannels to nbSubStreams.
MarcAntoine-Arnaud
added a commit
that referenced
this pull request
Jul 25, 2014
Refactoring & minor updates
cchampet
pushed a commit
to cchampet/avTranscoder
that referenced
this pull request
Jan 12, 2015
Fix GOP structure analysis (and add commented isClosedGop method needing a FFmpeg patch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.