forked from wesbos/JavaScript30
-
Notifications
You must be signed in to change notification settings - Fork 0
Release/201612142113 pull from wes bos #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aventinesolutions
merged 37 commits into
develop
from
release/201612142113_pull_from_WesBos
Dec 14, 2016
Merged
Release/201612142113 pull from wes bos #1
aventinesolutions
merged 37 commits into
develop
from
release/201612142113_pull_from_WesBos
Dec 14, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the instant function call
Fix typos and extra code
Fixes title of 2nd challenge
This is a random selection of female inventors for the dataset
A random selection of female inventors for the dataset along with proposed change in const name.
In your video you still sort on the first name of the array but you called it `aLast` and `bLast` but they where in the first position of the array like this: `const [aLast, aFirst]` when changed to `const [aFirst, aLast]` it will filter on the second part of the array. There for it will sort on the last name. To bad there is no way to pull request your video.
04 - Array Cardio Day 1, 7. sort Exercise | make it so it sorts on last name
Removed the extra code from the start file
Fix typo: thank > thanks
typo: inventory > inventors'
female inventors + change in const name
adding women inventors
As requested by Wes Bos.
Update readme.md
Massages Array Cardio challenges 💪
Reset the contents of index-START and style-START to reflect the contents before running through the video.
spelling.
copy-pasta typo
Update index.html
…-style-start 24 - Sticky Nav: reset index and style START
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐻