Add CHANGELOG to dynamodb encryption client for java #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts a changelog, which follows the same format as the encryption sdk for java.
mattsb42-aws
reviewed
Dec 5, 2018
CHANGELOG.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.2.0 | |||
There was a problem hiding this comment.
Something that I always find very useful in changelogs is the date when that version was released (ex[1]). This also makes it clear if a version has not yet been released and we are just noting the changes accruing that will be in that version once we publish it.
[1] https://github.com/aws/aws-encryption-sdk-python/blob/master/CHANGELOG.rst#138----2018-11-15
There was a problem hiding this comment.
I like the minor / bugfix format in the python changelog, will update to include the date.
mattsb42-aws
reviewed
Dec 5, 2018
mattsb42-aws
approved these changes
Dec 5, 2018
seebees
pushed a commit
that referenced
this pull request
Dec 12, 2023
Adds a flag to ignore case on Rsa JceMasterKey. This will avoid warning users about unsupported lowercase algorithm names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts a changelog, which follows the same format as the encryption sdk
for java.
(For release of 1.2.0)
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.