Skip to content

Upgrade aws sdk to upgrade guzzle #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Upgrade aws sdk to upgrade guzzle #105

merged 2 commits into from
Sep 12, 2016

Conversation

astrojason
Copy link

guzzle/guzzle has been abandoned

@cjyclaire
Copy link
Contributor

@astrojason We do have support for SDK V3 in all v3 release for aws-sdk-php-laravel

@astrojason
Copy link
Author

This is for the v1, laravel 4 branch

@douglasmiguel
Copy link

Yes, please.
I have the same problem.

"Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead."

@cjyclaire
Copy link
Contributor

@astrojason Okay, before I merged the changes and tag a release, in consideration of backwards-compatibility, could you also change the version constant to have a minor version bump that in case this might break someone?

@astrojason
Copy link
Author

@cjyclaire Updated version constant

@cjyclaire
Copy link
Contributor

@astrojason Great, thanks!

@cjyclaire cjyclaire merged commit d7d493f into aws:1.0 Sep 12, 2016
@GrahamCampbell
Copy link
Contributor

This is a major breaking change to 1.x though?

@cjyclaire
Copy link
Contributor

That's true, I revert the change, fix the tag.

@astrojason Considering it's a major break, in terms of using aws-sdk-php v3, it's better practice to use compatible laravel version according to README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants