Removed illuminate/foundation as a requirement #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuminate/foundation has been deprecated. Proposed a workaround that imports the entire framework.
| "illuminate/foundation": "4.*", | ||
| "illuminate/support": "4.*" | ||
| "illuminate/support": "4.*", | ||
| "laravel/framework": "4.*" |
There was a problem hiding this comment.
We don't need this, just the support dependency will do.
|
👍 |
|
This is needed for anyone using newer versions of L4. |
jeremeamia
added a commit
that referenced
this pull request
May 29, 2015
Removed illuminate/foundation as a requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found out today that illuminate/foundation has been abandoned.
I propose a workaround that imports the entire framework, this provides the same foundation code that illuminate/foundation had. This is to ensure that anyone who still uses laravel 4.* will be able to deploy this package to their projects.