Add support for default configuration modes #2624
Conversation
…values through rake task
This reverts commit a5a9e8e.
|
Reminder: Confirm core version requirements before merge/release. |
tasks/update-defaults-mode.rake
Outdated
| puts "Loading defaults from: #{defaults_file}" | ||
| defaults = JSON.load(File.read(defaults_file)) | ||
|
|
||
| default_mode_docs = ["<p>The following `:default_mode` values are supported: </p>"] |
There was a problem hiding this comment.
Should these hardcoded strings live in the actual documentation, and maybe just code generate multiple dynamic sections like all of the modes and configuration maps?
There was a problem hiding this comment.
Yeah - I think that makes sense.
There was a problem hiding this comment.
NVM - this doesn't work as we need all of the links to be processed together by kramdown.
| @@ -63,6 +63,20 @@ module S3 | |||
| 'https://s3.us-east-1.amazonaws.com/') | |||
| end | |||
|
|
|||
| it 'can be set through defaults mode' do | |||
There was a problem hiding this comment.
Did you update all of the plugin tests?
There was a problem hiding this comment.
Yeah - every option that has changed has a new test.
|
It's a bit unclear how to use default config mode. |
|
You can set the It is just a canned way of overwriting some other config options. You may be better off just overwriting any options you want instead. |
|
Thank you! |
Adds support for the
default_modeconfiguration value that standardizes SDK default configurations.Add a new aws-defaults pseudo gem (similar to seahorse and sts/sso) in core which has:
DefaultsModeConfigResolver- responsible for logic to resolve defaults from a defaults mode (as well as environment detection).DefaultsModeConfigurationmodule - documentation and config values code generated from the cross SDK values.default_modeis added as an option by theDefaultsModeplugin. Resolution of defaults is done through updates to the default blocks on the appropriate existing config options.This change also adds support for the
ssl_timeoutconfig option for net http.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!