fixed bug with incorrect host when endpoint nil #693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added integration tests for copy snapshot and copy encrypted snapshot. Fixes aws#561
There are two notable behavior changes: 1. We do not yield to a block when there is zero content. This was causing an exception upstream in the code (in the case of client-side encryption, a cipher#update exception for no content). 2. We moved the truncated body check to be outside the Net::HTTP block, so that we don't clobber exceptions that were raised before that check. These issues have existed in the code for some time, but negative effects were only recently realized when a change in OpenSSL behavior resulted in empty packets being sent over the wire - yielding these caused exceptions downstream, rather than waiting for the content to be sent. That issue should no longer occur. Resolves issue aws#557.
This caused a regression in Ruby 1.8.7 which does not support %L in `strftime`. Fixes aws#563
Added require 'json' to ensure no failure when calling using AWS.config.... Fixes aws#566
This change adds support for delivery notifications to Amazon Simple Email Service.
…fecycle_configuration.update
…ints files and instead adding a hash to the HostedZone class to map region to id.
Add support for T2 instances.
References: aws#568
Adding support to the AWS::Core::Endpoints module for getting hosted zon...
The test was failing if it was run on a EC2 instance with a valid instance profile.
Two tests were failing periodically due to hash ordering issues. Now comparing the sorted values of the hashes under test to resolve the ordering issue.
[s3] Do not prepend metadata keys if they start with x-amz
Allow arguments in bucket.lifecycle_configuration.update
Re-establish Ruby 1.8.7 compatibility
Enabled 100-continue behavior for Amazon S3 by default. Fixes aws#241
trevorrowe
added a commit
that referenced
this pull request
Feb 5, 2015
|
This has been merged into aws-sdk-v1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was when you set endpoint as nil there's no host. And so it leads to the output as this
2.2.0 (main):0 > s3.buckets['transfer.celluloidheaven.net'].objects['test'].url_for(:read, :endpoint => nil, :secure => false) => #<URI::HTTP http:/transfer.celluloidheaven.net/test?AWSAccessKeyId=XXXX&Expires=XXXX&Signature=XXXX>Fixed now.