Skip to content

Constraints on attrs package breaks compatibility with apache-airflow python sdk #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
n-bkoe opened this issue Mar 5, 2025 · 1 comment
Closed

Constraints on attrs package breaks compatibility with apache-airflow python sdk #5075

n-bkoe opened this issue Mar 5, 2025 · 1 comment
Labels
component: pysdk-team Related to SageMaker Python SDK Core Issues type: feature request

Comments

@n-bkoe
Copy link

n-bkoe commented Mar 5, 2025

Describe the bug

The current pyproject requires attrs>=23.1.0,<24, while the airflow libraries has required at least 24 since version 2.10.0 (see here)

Would it be possible to relax the upper bound to include attrs>=24 ?

To reproduce

With uv, use this pyproject

[project]
name = "template-airflow"
version = "0.1.0"
description = "Airflow template repository"
readme = "README.md"
requires-python = ">=3.11"
dependencies = [
    "apache-airflow[amazon]==2.10.3",
    "sagemaker>=2.197.1",
]

and run uv pip compile -o requirements.txt pyproject.toml --constraints https://raw.githubusercontent.com/apache/airflow/constraints-2.10.3/constraints-3.11.txt
@nargokul nargokul added the component: pysdk-team Related to SageMaker Python SDK Core Issues label Apr 14, 2025
nargokul added a commit to nargokul/sagemaker-python-sdk that referenced this issue May 27, 2025
@nargokul
Update Attrs version to widen support
63a31ae 
**Description**

aws#5075

**Testing Done**
Running unit and integ tests

Unit and integ tests passing indicate that this version upgrade does not break anything
@nargokul nargokul mentioned this issue May 27, 2025
Open
10 tasks
@nargokul
Copy link
Contributor

nargokul commented Jun 2, 2025

This changed has been merged and released.
https://pypi.org/project/sagemaker/2.245.0/

@nargokul nargokul closed this as completed Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: pysdk-team Related to SageMaker Python SDK Core Issues type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@n-bkoe @nargokul @pintaoz-aws