Skip to content

SMP PT upgrade to 2.1 #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 5, 2024
Merged

SMP PT upgrade to 2.1 #4404

merged 11 commits into from
Feb 5, 2024

Conversation

adtian2
Copy link
Collaborator

@adtian2 adtian2 commented Feb 1, 2024

Issue #, if available:

Description of changes:
SMP is releasing a new version that is compatible with PT 2.1.2

Testing done:
Using this version, I ran using a SM notebook and tested the paths of submitting a job

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adtian2 adtian2 requested a review from a team as a code owner February 1, 2024 23:16
@adtian2 adtian2 requested review from mufaddal-rohawala and removed request for a team February 1, 2024 23:16
benieric
benieric reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@benieric benieric self-assigned this Feb 2, 2024
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 79ee826
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 79ee826
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 79ee826
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

benieric
benieric reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2b86f1c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2b86f1c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2b86f1c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2b86f1c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (8b206ba) 86.94% compared to head (3d5bff8) 86.77%.
Report is 5 commits behind head on master.

Files Patch % Lines
...rc/sagemaker/serve/builder/transformers_builder.py 74.82% 36 Missing ⚠️
...er/serve/model_server/multi_model_server/server.py 38.46% 32 Missing ⚠️
src/sagemaker/serve/utils/predictors.py 73.33% 4 Missing ⚠️
src/sagemaker/serve/mode/local_container_mode.py 40.00% 3 Missing ⚠️
...rc/sagemaker/serve/mode/sagemaker_endpoint_mode.py 33.33% 2 Missing ⚠️
src/sagemaker/jumpstart/session_utils.py 98.11% 1 Missing ⚠️
src/sagemaker/serve/builder/model_builder.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
- Coverage   86.94%   86.77%   -0.17%     
==========================================
  Files        1203      386     -817     
  Lines      107211    35636   -71575     
==========================================
- Hits        93211    30924   -62287     
+ Misses      14000     4712    -9288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benieric
benieric reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 3d5bff8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 3d5bff8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 3d5bff8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 3d5bff8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 3d5bff8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@benieric benieric merged commit a906921 into aws:master Feb 5, 2024
Captainia pushed a commit to Captainia/sagemaker-python-sdk that referenced this pull request Feb 29, 2024
@adtian2
SMP PT upgrade to 2.1 (aws#4404)
a3ba701 
* adding pt 2.1 support for smp

* adding supported PT versions of 2.1.2

* bug fix in smp tests

* adding 2.1.2

* adding 2.1.0 for Herring changes

* changed image_uri generation logic for PT version 2.1.2 for smp

* fixed this unit test to reflect changes for version PT 2.1

---------

Co-authored-by: Andrew Tian <tinandr@amazon.com>
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
@adtian2 @jiapinw
SMP PT upgrade to 2.1 (aws#4404)
9f9d835 
* adding pt 2.1 support for smp

* adding supported PT versions of 2.1.2

* bug fix in smp tests

* adding 2.1.2

* adding 2.1.0 for Herring changes

* changed image_uri generation logic for PT version 2.1.2 for smp

* fixed this unit test to reflect changes for version PT 2.1

---------

Co-authored-by: Andrew Tian <tinandr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benieric benieric benieric approved these changes

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala mufaddal-rohawala is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@benieric benieric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adtian2 @mufaddal-rohawala @codecov-commenter @benieric