Skip to content

fix: pin mamba version to 24.11.3-2 to avoid inconsistent test runs #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

nmadan
Copy link
Member

@nmadan nmadan commented Apr 29, 2025

Issue #, if available:

Description of changes:
The latest mamba update was causing mamba env update -n integ_test_env --file /sagemaker_remote_function_workspace/conda_env.yml command to get stuck. I pinned the download url to the previous version and the training job succeeded as expected.

Testing done:
Tested locally using

export IGNORE_COVERAGE=- ; tox -e py310 -- -s -vv tests/integ/sagemaker/workflow/test_step_decorator.py::test_decorator_with_conda_env ; unset IGNORE_COVERAGE

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nmadan nmadan requested a review from a team as a code owner April 29, 2025 19:57
@nmadan nmadan requested a review from sage-maker April 29, 2025 19:57
@nmadan nmadan changed the title fix: increase pipeline execution wait duration fix: pin mamba version to 24.11.3-2 to avoid inconsistent test runs May 1, 2025
@Aditi2424
Copy link
Contributor

=========================== short test summary info ============================
FAILED tests/integ/sagemaker/serve/test_serve_js_deep_unit_tests.py::test_js_model_with_optimize_quantization_on_pre_optimized_model_requests_are_expected
FAILED tests/integ/sagemaker/serve/test_serve_js_deep_unit_tests.py::test_js_model_with_optimize_speculative_decoding_config_gated_requests_are_expected
FAILED tests/integ/sagemaker/serve/test_serve_js_deep_unit_tests.py::test_js_model_with_optimize_sharding_and_resource_requirements_requests_are_expected

The failing Integ tests are failing in the CI Health too - https://github.com/aws/sagemaker-python-sdk/actions/runs/14775013614/job/41481587678 and need to be fixed separately.

@Aditi2424 Aditi2424 merged commit 0dae5c9 into aws:master May 1, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants