Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/logger/src/Logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
getXRayTraceIdFromEnv,
isDevMode,
} from '@aws-lambda-powertools/commons/utils/env';
import type { Context, Handler } from 'aws-lambda';
import type { Callback, Context, Handler } from 'aws-lambda';
import merge from 'lodash.merge';
import {
LogJsonIndent,
Expand Down Expand Up @@ -493,19 +493,17 @@ class Logger extends Utility implements LoggerInterface {
// access `myClass` as `this` in a decorated `myClass.myMethod()`.
descriptor.value = async function (
this: Handler,
event,
context,
callback
...args: [unknown, Context, Callback]
) {
loggerRef.refreshSampleRateCalculation();
loggerRef.addContext(context);
loggerRef.logEventIfEnabled(event, options?.logEvent);
loggerRef.addContext(args[1]);
loggerRef.logEventIfEnabled(args[0], options?.logEvent);
if (options?.correlationIdPath) {
loggerRef.setCorrelationId(event, options?.correlationIdPath);
loggerRef.setCorrelationId(args[0], options?.correlationIdPath);
}

try {
return await originalMethod.apply(this, [event, context, callback]);
return await originalMethod.apply(this, args);
} catch (error) {
if (options?.flushBufferOnUncaughtError) {
loggerRef.flushBuffer();
Expand Down
8 changes: 3 additions & 5 deletions packages/metrics/src/Metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -598,17 +598,15 @@ class Metrics extends Utility implements MetricsInterface {
// access `myClass` as `this` in a decorated `myClass.myMethod()`.
descriptor.value = async function (
this: Handler,
event: unknown,
context: Context,
callback: Callback
...args: [unknown, Context, Callback]
): Promise<unknown> {
if (captureColdStartMetric) {
metricsRef.captureColdStartMetric(context.functionName);
metricsRef.captureColdStartMetric(args[1].functionName);
}

let result: unknown;
try {
result = await originalMethod.apply(this, [event, context, callback]);
result = await originalMethod.apply(this, args);
} finally {
metricsRef.publishStoredMetrics();
}
Expand Down
19 changes: 10 additions & 9 deletions packages/parser/src/parserDecorator.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { HandlerMethodDecorator } from '@aws-lambda-powertools/commons/types';
import type { StandardSchemaV1 } from '@standard-schema/spec';
import type { Context, Handler } from 'aws-lambda';
import type { Callback, Context, Handler } from 'aws-lambda';
import { parse } from './parser.js';
import type { Envelope, ParserOptions } from './types/index.js';
import type { ParserOutput } from './types/parser.js';
Expand Down Expand Up @@ -75,21 +75,22 @@ export const parser = <
>(
options: ParserOptions<TSchema, TEnvelope, TSafeParse>
): HandlerMethodDecorator => {
return (_target, _propertyKey, descriptor) => {
// biome-ignore lint/style/noNonNullAssertion: The descriptor.value is the method this decorator decorates, it cannot be undefined.
const original = descriptor.value!;
return (
_target: unknown,
_propertyKey: string | symbol,
descriptor: PropertyDescriptor
) => {
const original = descriptor.value;

const { schema, envelope, safeParse } = options;

descriptor.value = async function (
this: Handler,
event: ParserOutput<TSchema, TEnvelope, TSafeParse>,
context: Context,
callback
...args: [ParserOutput<TSchema, TEnvelope, TSafeParse>, Context, Callback]
) {
const parsedEvent = parse(event, envelope, schema, safeParse);
const parsedEvent = parse(args[0], envelope, schema, safeParse);

return original.call(this, parsedEvent, context, callback);
return original.apply(this, [parsedEvent, ...args.slice(1)]);
};

return descriptor;
Expand Down
Loading