Fix "std-compat" CI to actually test what it's supposed to #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The "std-compat" CI isn't doing what it's supposed to: building aws-crt-cpp with different versions of the C++ std.
It broke accidentally when this commit stopped passing
--env CXXFLAGSto the container.Description of changes:
Fix it, so C++ version is passed to the container.
Set it via
CMAKE_CXX_STANDARD=11, instead of viaCXXFLAGS=-std=c++11, since this is the "more correct" way to tell CMake the C++ standard you want. Doing it viaCXXFLAGS=-std=c++11can (depending on the version of CMake you're using) force compiler extensions to be disabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.