Initialize checksums explicitly #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Mar 27, 2025
waahm7
approved these changes
Mar 27, 2025
| @@ -48,6 +49,7 @@ namespace Aws | |||
| aws_s3_library_init(allocator); | |||
| aws_event_stream_library_init(allocator); | |||
| aws_sdkutils_library_init(allocator); | |||
| aws_checksums_library_init(allocator); | |||
There was a problem hiding this comment.
technically we don't need to do this since aws-c-s3 will do it.
There was a problem hiding this comment.
yes, but i think its better to be explicit here and just init what you use without relying on other things doing it for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Call checksums module init explicitly to avoid any thread safety warnings.
USE_WINDOWS_DLL_SEMANTICS is renamed to AWS_CRT_USE_WINDOWS_DLL_SEMANTICS to be consistent with other repos
and removing some logic for gcc < 4, since we stopped supporting it long ago
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.