fix clang error in string view #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6596ff4 to
620faee
Compare
Closed
1 task
…out what is different because I couldn't tell at 1st, or 2nd, or 3rd glance
graebm
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-cpp#3370
Description of changes:
fixes a clang warning as error that some the sdk users are seeing, similar issue seen in fmt. Since compilers older than gcc 4.9 do not support the correct syntax we add a definition to existing "ancient compilers" block so that we can handle it correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.