Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1285 Document SecretsManager cross-account access. #1302

Merged
merged 1 commit into from
Dec 18, 2024
Merged

#1285 Document SecretsManager cross-account access. #1302

merged 1 commit into from
Dec 18, 2024

Conversation

mmaeller
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Extended documentation of SecretsManager implementation capable of using ARNs.

💡 Motivation and Context

#1285

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Dec 18, 2024
@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 RC1 milestone Dec 18, 2024
@maciejwalkowiak maciejwalkowiak added the component: secrets-manager Secrets Manager integration related issue label Dec 18, 2024
@maciejwalkowiak maciejwalkowiak merged commit 6150974 into awspring:main Dec 18, 2024
1 check passed
@maciejwalkowiak maciejwalkowiak mentioned this pull request Dec 18, 2024
Closed
@maciejwalkowiak
Copy link
Contributor

Thanks @mmaeller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatejNedic MatejNedic MatejNedic approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak maciejwalkowiak is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: secrets-manager Secrets Manager integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Milestone
3.3.0 RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@mmaeller @maciejwalkowiak @MatejNedic