Fix function name in root command comment #660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #659
The root command behaves slightly differently than other commands, in terms of naming.
Other commands - say
download
- have all their functions prefixed by the name of the command -download_command
,download_usage
etc.The root command has a split behavior: The command function is named
root_command
, while other functions are prefixed by the CLI name -download_usage
.Due to this behavior, we cannot just update the
Script::Command.function_name
method:bashly/lib/bashly/script/command.rb
Lines 67 to 69 in 14f1c94
and instead, we have to address this particular case with a local template condition: