Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.19.0
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.20.0
Choose a head ref
  • 19 commits
  • 48 files changed
  • 8 contributors

Commits on Mar 5, 2023

  1. chore: fix some lingering GH archive URLs (#1108)

    This was pointed out in a thread on bazel-discuss@googlegroups.com
    alexeagle authored Mar 5, 2023
    Configuration menu
    Copy the full SHA
    51458e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. feat: add bzlmod support for gazelle plugin (#1077)

    * feat: add optional pkg alias generation to pip_repository
    
    * feat: support using aliases in gazelle
    
    * doc: migrate gazelle example to use user friendly aliases
    
    * feat: gazelle supports bzlmod
    
    * chore: update gazelle plugin deps
    
    * chore: bazel run //:gazelle
    
    * fix: remove deps that are imported as bazel deps
    
    See: bazel-contrib/bazel-gazelle#1403
    
    * ci: add build_file_generation to show that we support bzlmod
    aignas authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    7d82f06 View commit details
    Browse the repository at this point in the history
  2. docs: Simplify pull request template (#1100)

    The existing template is very verbose with many of the lines not being
    applicable to any given PR. This also makes the PR description poorly
    suitable for a commit description.
    
    By having a cleaner PR description that is commit message friendly,
    whoever merges the PR can more easily create a meaningful commit
    message. It also allows other maintainer's to clean up the description
    prior to it being merged.
    rickeylev authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    de8f428 View commit details
    Browse the repository at this point in the history
  3. chore: fix syntax that stardoc misunderstands as HTML (#1110)

    Update requirements.bzl
    alexeagle authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c73dc0c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    244c606 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ba98a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. feat: add bzl_library for defs.bzl and its dependencies (#1115)

    This is so that the transitive dependencies of defs.bzl can be easily
    found and validated; some Google internal tooling does this validation.
    
    The old comment indicated bzl_library wasn't used to avoid a dependency
    on skylib, however, we've since added a dependency on skylib.
    
    Work towards #1069
    rickeylev authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7ffe2f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8400610 View commit details
    Browse the repository at this point in the history
  3. fix: generation of toolchain aliases //:defs.bzl file. (#1088)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [X] Bugfix
    - [ ] Feature (please, look at the "Scope of the project" section in the
    README.md file)
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    With `common --experimental_enable_bzlmod` option defs.bzl is generated
    as
    ```
    load("@rules_python~override//python/config_settings:transition.bzl", _py_binary = "py_binary", _py_test = "py_test")
    load("@rules_python~override//python:pip.bzl", _compile_pip_requirements = "compile_pip_requirements")
    ```
    and these lines cause a problem at
    ```
    load("@python3_9//:defs.bzl", "interpreter")
    ```
    as
    ```
    
    ERROR: .../BUILD:25:11: error loading package 'src': at .../external/rules_python~override~python~python3_9/defs.bzl:4:6: Unable to find package for @[unknown repo 'rules_python~override' requested from @rules_python~override~python~python3_9]//python:pip.bzl: The repository '@[unknown repo 'rules_python~override' requested from @rules_python~override~python~python3_9]' could not be resolved: No repository visible as '@rules_python~override' from repository '@rules_python~override~python~python3_9'. and referenced by '...'
    ```
    
    
    Issue Number: N/A
    
    
    ## What is the new behavior?
    
    Generated load statements
    ```
    load("@@rules_python~override//python/config_settings:transition.bzl", _py_binary = "py_binary", _py_test = "py_test")
    load("@@rules_python~override//python:pip.bzl", _compile_pip_requirements = "compile_pip_requirements")
    ```
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    
    ## Other information
    oxidase authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5ff514a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. feat: make variable substitution for py_wheel abi, python_tag args (#…

    …1113)
    
    Expands make variables in to `abi` and `python_tag` attributes
    
    ---------
    
    Co-authored-by: Richard Levasseur <richardlev@gmail.com>
    stonier and rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1c5b92b View commit details
    Browse the repository at this point in the history
  2. feat: add bzl_library for proto.bzl (#1116)

    This is mostly so Google internal tooling can find the complete deps,
    but also as a best practice for consumption by other rules and tools.
    rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3aa221f View commit details
    Browse the repository at this point in the history
  3. cleanup: Remove license comment in proto build file (#1118)

    The license comments aren't necessary anymore.
    rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    25e4175 View commit details
    Browse the repository at this point in the history
  4. fix: restrict proto package visibility to private (#1117)

    This is to prevent accidentally leaking targets that shouldn't be
    accessible. The `:python_toolchain` target is public because it's an
    implicit dependency of `py_proto_library`.
    rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9ef11b9 View commit details
    Browse the repository at this point in the history
  5. cleanup: rename proto BUILD -> BUILD.bazel (#1119)

    The rest of the project uses BUILD.bazel
    rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    31d0efd View commit details
    Browse the repository at this point in the history
  6. feat: bzl file per rule/provider (#1122)

    This is basically a performance optimization. Bazel can only see that a
    bzl file changed, not the particular contents. This means that any
    downstream bzl file loading it is invalidated, even if it doesn't load
    any of the affected code. As an example, if a package only loads
    `py_library.bzl`, then changing `py_test.bzl` doesn't need to invalidate
    all libraries.
    
    * Also removes some more extraneous license comments
    
    Work towards #1069
    rickeylev authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    756264a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. cleanup: fix typo: libraries, not libaries (#1127)

    Silent r's are tricky.
    rickeylev authored Mar 11, 2023
    Configuration menu
    Copy the full SHA
    c0c08a3 View commit details
    Browse the repository at this point in the history
  2. feat: add public entry point for PyCcLinkParamsInfo (#1128)

    This provides a public entry point for loading the underlying
    `PyCcLinkParamsProvider` provider that is built into Bazel. This
    provider isn't yet usable from Bazel, but adding a loadable way for it
    to migrate off the built-in rules is the first step.
    
    Work towards #1069
    rickeylev authored Mar 11, 2023
    Configuration menu
    Copy the full SHA
    4e3d01c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. cleanup: reformat defs.bzl doc string. (#1126)

    The extraneous newlines were bothering me.
    rickeylev authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    31bc04b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Configuration menu
    Copy the full SHA
    c394c46 View commit details
    Browse the repository at this point in the history
Loading