Skip to content

Transfer rules_python to bazel-contrib #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
rickeylev opened this issue Feb 28, 2025 · 12 comments
Closed
2 of 4 tasks

Transfer rules_python to bazel-contrib #2638

rickeylev opened this issue Feb 28, 2025 · 12 comments

Comments

@rickeylev
Copy link
Collaborator

rickeylev commented Feb 28, 2025

Description:

This issue proposes transferring the rules_python repository from the bazelbuild GitHub organization to the bazel-contrib GitHub organization, which is owned by the Community for Bazel project under the Linux Foundation.

Impacts:

  • GitHub issues & PRs will be transferred to the new repository.
  • Branch protection rules will need to be transferred to the new repository.
  • Individual maintainers will be transferred to the new repository.
  • GitHub teams will NOT be transferred to the new repository and will need to be re-created.
  • Bazel CI configurations will need to be updated to point to the new repository.
  • Read more on Transferring a repository from GitHub documentation.

Checklist:

  • Obtain approval from the current project maintainers: Done

    • me (rickeylev), @aignas, @groodt (effective maintainers, from community)
    • @comius (Bazel)
    • @oprypin (Google python team)
      See the internal email thread "Moving rules_python to bazel-contrib"
  • Obtain approval from the bazel-contrib SIG (@alexeagle).

  • Initiate the transfer process on GitHub (@meteorcloudy) -- before transferring, please sync with @rickeylev (I want to send an announcement and schedule a date)

  • Update Bazel CI settings and confirm presubmit & postsubmit work (@meteorcloudy).

@oprypin
Copy link
Contributor

oprypin commented Feb 28, 2025

Regarding this:

GitHub issues & PRs will be transferred to the new repository.

I just want to make sure that the repository is moved, so that there's no need to actually transfer any constituent parts of it, it just gets a new name all in one "move" operation. All URLs keep working too, just with a redirect. The mentioned "Transferring a repository" describes such a "move" operation, so that's all good.

Bazel CI configurations will need to be updated to point to the new repository.

If done that way, maybe they will not even necessarily need to be updated, but of course it would be a good followup anyway.

@rickeylev rickeylev pinned this issue Mar 1, 2025
@meteorcloudy
Copy link
Contributor

@oprypin Yes, everything you described is exactly what will happen if we transfer the repo to bazel-contrib

@alexeagle
Copy link
Contributor

I'm curious how this affects the sync to google3, per https://docs.google.com/spreadsheets/d/18oJBpAAc9hyT-3oJtque6bAxTKT4nsnryRtpccHXITw/edit?gid=186550915#gid=186550915 there's still a sync right?

@meteorcloudy
Copy link
Contributor

That's a good question, @rickeylev @oprypin do we still plan to import rules_python after the move, it should still be possible because it's just like importing any other third party dependency.

However, should we at least set up some minimal integration tests to make sure the internal & external python rules don't diverge too far?

@oprypin
Copy link
Contributor

oprypin commented Mar 4, 2025

Hi. For the moment, I'd be more comfortable with discussing Google-internal matters on the same internal email thread.

@meteorcloudy
Copy link
Contributor

@oprypin Makes sense

@alexeagle
Copy link
Contributor

Today's SIG meeting: we reviewed the criteria from https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html#adding-criteria and no concerns voiced, so it's approved!

@meteorcloudy
Copy link
Contributor

@rickeylev ping me when you are ready for the transfer

@rickeylev
Copy link
Collaborator Author

@meteorcloudy Can we do the transfer Monday, Mar 17th? Any time is fine. (Or there abouts, doesn't have to be exactly that day).

@meteorcloudy
Copy link
Contributor

No problem, will do.

@meteorcloudy
Copy link
Contributor

I will start the transfer shortly.

@meteorcloudy
Copy link
Contributor

This is done, testing on CI: https://buildkite.com/bazel/rules-python-python/builds/10618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants