-
-
Notifications
You must be signed in to change notification settings - Fork 591
Support for operating-system-specific requirements file #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
touch |
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
Touch
…On Mon, Nov 22, 2021 at 14:50 github-actions[bot] ***@***.***> wrote:
This issue has been automatically marked as stale because it has not had
any activity for 180 days. It will be closed if no further activity occurs
in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks
for your contributions to rules_python!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#384 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAQT3YLMHRNZBZNOEAE7DUNLCMDANCNFSM4UBSSA2A>
.
|
+1 |
The macros are leaky and otherwise you have to read sources to find out about the kwargs Fixes bazel-contrib#384
🚀 feature request
Relevant Rules
load("@rules_python//python:pip.bzl", "pip_install")
Description
Our company uses both macOS and Linux (Ubuntu and Docker) as development / test / production platforms.
As recommended on Bazel #python Slack, we use a
requirements.in
file to producerequirements.txt
usingpip-compile
. This works great, except...The
requirements.txt
compilation process can be OS dependent. For example,ipython
has OS_dependent deps via':sys_platform == "darwin"': ["appnope"],
.I can't figure out how to make
requirements.txt
be dependent on the operating system (platform?). There's only room for one in theWORKSPACE
declaration, andselect
statements don't work there.Relevant thread from Slack, from @thundergolfer:
Describe the solution you'd like
I'm not sure what the best solution is here. Can we do something in the rule to take a mapping and resolve it that way?
Describe alternatives you've considered
The main thing that seems like it would work without a rule change is a configure script that links to
requirements.txt.<platform>
. Seems heavyweight though.The text was updated successfully, but these errors were encountered: