Skip to content

allow specifying test timeout in gazelle_python_manifest #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garymm opened this issue Aug 24, 2022 · 2 comments · Fixed by #817
Closed

allow specifying test timeout in gazelle_python_manifest #802

garymm opened this issue Aug 24, 2022 · 2 comments · Fixed by #817

Comments

@garymm
Copy link
Contributor

garymm commented Aug 24, 2022 •
edited
Loading

allow specifying test size in gazelle_python_manifest

Relevant Rules

gazelle_python_manifest

Description

gazelle_python_manifest generates an sh_test.
In my case, bazel test complains that the specified timeout is too long:

WARNING: //:gazelle_python_manifest.test: Test execution time (0.2s excluding execution overhead) outside of range for MODERATE tests. Consider setting timeout="short" or size="small".

Describe the solution you'd like

A test_timeout parameter to gazelle_python_manifest.

Describe alternatives you've considered

Just ignoring the warning.

If this is acceptable I could try to contribute the PR.
@f0rmiga
Copy link
Member

f0rmiga commented Aug 30, 2022

A contribution is welcome! I think we can mark this test small no problem, they are supposed to also execute super fast even on large manifests.

garymm added a commit to garymm/rules_python that referenced this issue Aug 30, 2022
@garymm
specify timeout for gazelle manifest test
be231f4 
Fixes bazel-contrib#802
@garymm garymm mentioned this issue Aug 30, 2022
Merged
12 tasks
@garymm
Copy link
Contributor Author

garymm commented Aug 30, 2022

@f0rmiga #817

f0rmiga added a commit that referenced this issue Aug 30, 2022
@garymm @f0rmiga
specify timeout for gazelle manifest test (#817)
ad0b8f8 
Fixes #802

Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify timeout for gazelle manifest test garymm/rules_python
2 participants
@garymm @f0rmiga