-
-
Notifications
You must be signed in to change notification settings - Fork 589
compile_pip_requirements no longer uses predictable paths #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was able to reproduce this and it only seems to happen with the added |
Whoops. Sorry about that. Thanks for fixing it @f0rmiga! |
I can confirm that the problem is fixed in the new version, 0.15.1. Many thanks, @f0rmiga. |
The bug is back. Regression caused by fbf8bc1 according to my |
aignas
added a commit
to aignas/rules_python
that referenced
this issue
Jan 26, 2025
…g packages (bazel-contrib#2514) This reverts commit fbf8bc1. Also, update the CHANGELOG about the reverting. Fixes bazel-contrib#908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 bug report
Affected Rule
The issue is caused by the rule:
compile_pip_requirements
Is this a regression?
Yes, the previous version in which this bug was not present was: 0.13.0. It is present in 0.15.0. I didn't explicitly check 0.14.0, but I'll actually go one step further: a
git bisect
says the first bad commit is b15e15f. (Ping @philsc and @f0rmiga.)Description
As it says in python/pip_install/pip_compile.py:
I haven't double checked that that's the right file for this bug report, but the comment describes a desirable outcome that I'm no longer seeing.
🔬 Minimal Reproduction
See https://gist.github.com/vonschultz/9e242d1612ec70b1848057cce681e037. I'm using it with
bazelisk run :pip_dependencies.update
.🔥 Exception or Error
You see the problem in requirements_common_lock-txt:
Before b15e15f that line reads
which is the desired behavior.
🌍 Your Environment
Operating System:
Ubuntu 20.04
Output of
bazel version
:Rules_python version:
The text was updated successfully, but these errors were encountered: