refactor: py_wheel now a macro #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us the place to insert other targets produced by it, such as a publishing target. Part of #99
rickeylev
approved these changes
Jan 25, 2023
f0rmiga
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactoring that should have no user-visible effect.
This gives us the place to insert other targets produced by it, such as a publishing target.
Note: due to stardoc limitation, we have to expose two different symbols to the user in the docs.
I've linked them together and not tried to "hide" the fact that there's both a macro and a rule.
This way we don't have to duplicate all the docs for the attributes into the single docstring of the macro,
and declare all the matching parameters and remember to pass them through to the rule.
See docs preview: https://github.com/bazelbuild/rules_python/blob/bc38c7e28a5684fecd0d7dd38fffc00b763f6ad2/docs/packaging.md#py_wheel
Part of #99