Skip to content

fix(release): wrong replacement for $(location) during code review #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

alexeagle
Copy link
Contributor

No description provided.

@alexeagle alexeagle requested a review from f0rmiga February 8, 2023 15:29
@alexeagle alexeagle requested a review from rickeylev as a code owner February 8, 2023 15:30
@f0rmiga f0rmiga merged commit 6c8ae76 into main Feb 8, 2023
@f0rmiga f0rmiga deleted the publish branch February 8, 2023 16:33
@rickeylev
Copy link
Collaborator

Either is correct, with execpath being slightly better in theory, though effectively equivalent in practice.

rootpath basically means, "I expect this to be part of the binary's runfiles". This is somewhat more expensive as its an extra thing to materialize in runfiles and/or a packaged version of the binary (e.g subpar, zip, etc). It also means changing the file causes the binary to be rebuilt, which isn't actually necessary.

execpath basically means "I expect this to be provided as an input, but is not part of my binary itself". This is cheaper (just use the path to the already built file), and changing the file doesn't require rebuilding the binary itself.

(The Python rules ended up treating "data" as "binary-bundled-data", and now don't have a nice way of providing inputs to args without causing it to be bundled into the binary. Which is kind of unfortunate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants