refactor: Updating example to only use bzlmod and updates to example #1147
Conversation
ff20381 to
6412997
Compare
This commit updates the gazelle example to only use bzlmod. The example was previously set up to support bzlmod and also pre-bzlmod configurations, but moving forward I recommend just using bzlmod. We also missed a change in gazelle because bzlmod was picking up elements out of the WORKSPACE file. This commit removes the CI for the legacy bazel support as well.
This commit is contained in bazel-contrib#1146
6412997 to
8f2865f
Compare
|
/retest |
Gazelle supports Python unit test names that are either __test__.py or $(package_name)_test.py. I am refactoring the example to use both naming schemes.
|
Please rebase on #1146 as it has the empty |
|
@aignas i would like to remove the WORKSPACE file contents. The readme refers to GitHub tag that contains a working version not using bzlmod. I am using this code for a tutorial and leaving the WORKSPACE file will make it confusing. |
|
LGTM to refer to a historic version of the example. My only reservation would be the fact that this is being used as an integration test that may be useful to check for regressions. Maybe we could split this into two examples then? |
|
@aignas that is a fair point about the testing. I will modify the bzlmod example to include gazelle. I don't want to create yet another example that we are maintaining. |
|
@chrislovecnm, SGTM. Having the |
|
Closing because we have #1155. |
This commit updates the gazelle example to only use bzlmod. The example was previously set up to support bzlmod and also pre-bzlmod configurations, but moving forward I recommend just using bzlmod. We also missed a change in gazelle because bzlmod was picking up elements from the WORKSPACE file.
This commit removes the CI for the legacy bazel support as well.
I have updated one of the Python unit test names as well. Gazelle supports unit tests named test.py and also unit tests that are named the same as the package name and prefixed or suffixed with the word "test". This example now includes two of the
three naming schemes.
Another commit in this PR contains the code in #1146. That commit will fall
off once that PR is merged.