Skip to content

Stop using deprecated depset.union API #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Stop using deprecated depset.union API #180

merged 2 commits into from
Apr 16, 2019

Conversation

pstradomski
Copy link
Contributor

Stop using deprecated depset.union() API - use transitive argument to depset constructor instead.

Also switch to Args api for building the command line instead of flattening the depset.

Fixes #175

Copy link
Contributor

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, Pawel.

@brandjon brandjon merged commit f7a96a4 into bazel-contrib:master Apr 16, 2019
prebeta pushed a commit to prebeta/rules_python that referenced this pull request Jul 2, 2019
Also switch to using Args api for building args instead of flattening the depset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_depset_union
3 participants