Skip to content

feat(toolchain): add python 3.13.0, updated other versions and bumped coverage to 7.6.1 #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Oct 1, 2024

Description:

  • Added python 3.13.0 toolchain
  • Updated other versions in the toolchain
  • Bumped coverage version to 7.6.1
  • Updated CHANGELOG.md

@vfdev-5 vfdev-5 force-pushed the add-py-313-with-options branch 3 times, most recently from 8c0649b to dec4cad Compare October 2, 2024 09:18
@aignas
Copy link
Collaborator

aignas commented Oct 3, 2024

If you run the target defined in https://github.com/bazelbuild/rules_python/blob/413690fd09b068ab43ec9c1d37d20d8017747f2c/python/private/BUILD.bazel#L509 then rules_python will download all of the toolchains and print the checksums. The only thing you need to have is the list of empty platform identifiers, like:

    "3.13.0": {
        "url": "20240909/cpython-{python_version}rc2+20240909-{platform}-{build}.tar.gz",
        "sha256": {
            "aarch64-apple-darwin": "",
            "aarch64-unknown-linux-gnu": "",
            "ppc64le-unknown-linux-gnu": "",
            "s390x-unknown-linux-gnu": "",
            "x86_64-apple-darwin": "",
            "x86_64-pc-windows-msvc": "",
            "x86_64-unknown-linux-gnu": "",
        },
        "strip_prefix": "python",
    },

Sorry for being late here.

I think you also need to change any reference to MINOR_MAPPING, which is using the values in the folowing way. I think it is the only place. Adding a new Python version is always slightly annoying.

@vfdev-5 vfdev-5 force-pushed the add-py-313-with-options branch 2 times, most recently from 81c8ff9 to 46bde1b Compare October 3, 2024 09:41
@vfdev-5 vfdev-5 requested a review from aignas October 3, 2024 09:48
@aignas
Copy link
Collaborator

aignas commented Oct 7, 2024

And I see that a new release was cut that includes rc3: https://github.com/indygreg/python-build-standalone/releases/tag/20241002

@vfdev-5 vfdev-5 force-pushed the add-py-313-with-options branch 3 times, most recently from 6f46c8b to c2b255f Compare October 7, 2024 07:44
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Oct 7, 2024

@aignas thanks for the review! I agree there was something weird in the last commit in addition to a merge conflict with CHANGELOG.md. I fixed it and now it should be good.

@vfdev-5 vfdev-5 requested a review from aignas October 7, 2024 07:54
@vfdev-5 vfdev-5 changed the title Added python 3.13.0rc2 Added python 3.13.0rc3 Oct 7, 2024
@aignas
Copy link
Collaborator

aignas commented Oct 9, 2024

It seems that they were really fast: https://github.com/indygreg/python-build-standalone/releases/tag/20241008 contains the new builds and even the free-threading ones. I think adding the freethreading values in the TOOL_VERSIONS should be done in #2129.

@aignas
Copy link
Collaborator

aignas commented Oct 9, 2024

Could you also please add new binaries for coverage.py? This is needed since it is a new major version of python. I think just upgrading to the latest version (https://pypi.org/project/coverage/#files) should be sufficient. The docs on how to do it are in DEVELOPING.md file.

Feel free to leave notes there about how to add a new minor python version.

@vfdev-5 vfdev-5 force-pushed the add-py-313-with-options branch 2 times, most recently from 27c68d8 to ab15f78 Compare October 9, 2024 09:38
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented Oct 9, 2024

Could you also please add new binaries for coverage.py? This is needed since it is a new major version of python. I think just upgrading to the latest version (https://pypi.org/project/coverage/#files) should be sufficient. The docs on how to do it are in DEVELOPING.md file.

Feel free to leave notes there about how to add a new minor python version.

I'm not very sure how this works, I updated the PR, please review

@vfdev-5 vfdev-5 requested a review from aignas October 9, 2024 09:39
@vfdev-5 vfdev-5 force-pushed the add-py-313-with-options branch from ab15f78 to 0ca1259 Compare October 9, 2024 09:40
@vfdev-5 vfdev-5 changed the title Added python 3.13.0rc3 Added python 3.13.0, updated other versions and bumped coverage to 7.6.1 Oct 9, 2024
@aignas aignas changed the title Added python 3.13.0, updated other versions and bumped coverage to 7.6.1 feat(toolchain): add python 3.13.0, updated other versions and bumped coverage to 7.6.1 Oct 9, 2024
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aignas aignas added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bazel-contrib:main with commit bf4978c Oct 9, 2024
4 checks passed
@vfdev-5 vfdev-5 deleted the add-py-313-with-options branch October 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants