-
-
Notifications
You must be signed in to change notification settings - Fork 588
feat(toolchain): add python 3.13.0, updated other versions and bumped coverage to 7.6.1 #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c0649b
to
dec4cad
Compare
If you run the target defined in https://github.com/bazelbuild/rules_python/blob/413690fd09b068ab43ec9c1d37d20d8017747f2c/python/private/BUILD.bazel#L509 then rules_python will download all of the toolchains and print the checksums. The only thing you need to have is the list of empty platform identifiers, like: "3.13.0": {
"url": "20240909/cpython-{python_version}rc2+20240909-{platform}-{build}.tar.gz",
"sha256": {
"aarch64-apple-darwin": "",
"aarch64-unknown-linux-gnu": "",
"ppc64le-unknown-linux-gnu": "",
"s390x-unknown-linux-gnu": "",
"x86_64-apple-darwin": "",
"x86_64-pc-windows-msvc": "",
"x86_64-unknown-linux-gnu": "",
},
"strip_prefix": "python",
}, Sorry for being late here. I think you also need to change any reference to |
81c8ff9
to
46bde1b
Compare
And I see that a new release was cut that includes rc3: https://github.com/indygreg/python-build-standalone/releases/tag/20241002 |
6f46c8b
to
c2b255f
Compare
@aignas thanks for the review! I agree there was something weird in the last commit in addition to a merge conflict with CHANGELOG.md. I fixed it and now it should be good. |
It seems that they were really fast: https://github.com/indygreg/python-build-standalone/releases/tag/20241008 contains the new builds and even the free-threading ones. I think adding the freethreading values in the |
Could you also please add new binaries for Feel free to leave notes there about how to add a new minor python version. |
27c68d8
to
ab15f78
Compare
I'm not very sure how this works, I updated the PR, please review |
ab15f78
to
0ca1259
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description: