chore: bump twine dependencies and cleanup for 1.0 #2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g visibility Also fix a few bugs in the macro.
This is just for the uv backed one, right? Which is still private. My point being: it shouldn't be in the changelog, since it's just a private thing we use for ourselves. CI has some failures, I think its just missing WORKSPACE equivalent updates. |
rickeylev
approved these changes
Oct 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
This got accidentally committed in #2333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
requirements.txtfor all of the platforms forthe
twinecomponent that is used in wheel publishing rules. Before thatthe deps would be maintained by
dependabot.txtand it seems that it wouldconstantly exclude the
requirements.txtfrom the updated files, this meansthat the
requirements.txt(used on Linux) has gone out of sync and it wouldbe better to use a different mechanism to keep them in sync.
Hence the proposal is to:
uvto sync the requirements.requirements_linux.txtto explicitly highlight that the file is forLinux.
requirements.txtbut note that it is deprecated.requirements_universal.txtin case people want to use a singlerequirements file.
Whilst at it I had to:
rules_multirunas adev_dependencyuv pip compilerequirements for tools/publish