deps: use rules_cc 0.0.13 to support newer bazel versions #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b10bfc7 to
a005554
Compare
a005554 to
9522e15
Compare
aignas
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for WORKSPACE to work with newer bazel versions, rules_cc 0.0.13 or higher is
necessary. rules_cc then requires a newer protobuf version.
Note I couldn't figure out the minimum protobuf version, but 27.0 seems to work OK.
AFAIK only WORKSPACE is affected. Our bzlmod uses 0.0.9 and hasn't had issues.
Fixes #2310