Skip to content

fix: Correctly resolve macOS SDK paths #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 25, 2025

Conversation

shs96c
Copy link
Contributor

@shs96c shs96c commented Dec 6, 2024

XCode has facilities for accurately telling us where SDKs are installed. This is important to use, particularly when there may be multiple SDKs or versions of XCode installed.

Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please include a CHANGELOG note about the changed behaviour on the MacOS platforms.

XCode has facilities for accurately telling us where SDKs are installed.
This is important to use, particularly when there may be multiple SDKs
or versions of XCode installed.
@shs96c shs96c force-pushed the resolve-macos-sdks branch from 450fb76 to f4c5b61 Compare December 18, 2024 17:00
@aignas aignas requested a review from rickeylev March 7, 2025 05:43
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas enabled auto-merge March 7, 2025 05:54
@aignas aignas added this pull request to the merge queue Mar 25, 2025
Merged via the queue into bazel-contrib:main with commit 06f6f31 Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants