fix: make coverage work with bootstrap=script #2574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix.bootstrap.coverage
aignas
approved these changes
Jan 23, 2025
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 25, 2025
The script based bootstrap wasn't expanding the coverage template variable, which prevented coverage from activating. This was introduced when it was switched to the venv layout. To fix, expand the `%coverage_tool%` template variable as done elsewhere. Tested manually, per repro instructions in bazel-contrib#2572. While I did devise a way to mostly test this without an integration test, it was thwarted by some other bugs. Along the way, improve some of the bootstrap debug output and fix a comment. Fixes bazel-contrib#2572
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 25, 2025
The script based bootstrap wasn't expanding the coverage template variable, which prevented coverage from activating. This was introduced when it was switched to the venv layout. To fix, expand the `%coverage_tool%` template variable as done elsewhere. Tested manually, per repro instructions in bazel-contrib#2572. While I did devise a way to mostly test this without an integration test, it was thwarted by some other bugs. Along the way, improve some of the bootstrap debug output and fix a comment. Fixes bazel-contrib#2572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script based bootstrap wasn't expanding the coverage template variable, which prevented
coverage from activating. This was introduced when it was switched to the venv layout.
To fix, expand the
%coverage_tool%template variable as done elsewhere.Tested manually, per repro instructions in #2572. While I did devise a way to mostly
test this without an integration test, it was thwarted by some other bugs.
Along the way, improve some of the bootstrap debug output and fix a comment.
Fixes #2572