chore: remove old versions of Python 3.8 #2700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 has reached EOL and this PR removes old toolchains and most
of the tests. Users can still use it if they register the toolchains
themselves, but
rules_python
will no longer keep testing the toolchains.Removing the toolchains all-together will be done at a later stage which
may require us to be more clever how we handle asks to include
3.8
. Maybewe can just fail if the user asks for a python version that does not exist,
but I am concerned that
rules_python
depending onprotobuf
may pull incode that requests
3.8
. I'll look at this at some later time.