fix: support gazelle generation_mode:update_only #2708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
reviewed
Mar 29, 2025
gazelle/pythonconfig/pythonconfig.go
Outdated
| @@ -134,12 +134,20 @@ type Configs map[string]*Config | |||
|
|
|||
| // ParentForPackage returns the parent Config for the given Bazel package. | |||
| func (c *Configs) ParentForPackage(pkg string) *Config { | |||
There was a problem hiding this comment.
Since map is a reference type, could you please update the receiver arg to be a type of c Configs please?
Suggested change
| func (c *Configs) ParentForPackage(pkg string) *Config { | |
| func (c Configs) ParentForPackage(pkg string) *Config { |
| if dir == "" { | ||
| return nil | ||
| } | ||
| pkg = dir |
There was a problem hiding this comment.
Could you add a unit test for this new logic? Just testing the Configs in isolation would be sufficient.
Right now it is a little bit hard to read and having tests would help understand what this has to do.
There was a problem hiding this comment.
I've added a few basic tests for this method.
There should probably be some additional full tests for update_only and mixing that with the different python_generation_mode modes but I'm not familiar enough with it to do in this initial PR.
552417e to
956cff8
Compare
956cff8 to
3410bf2
Compare
jbedard
commented
Apr 4, 2025
| @@ -125,21 +125,28 @@ const ( | |||
|
|
|||
| // defaultIgnoreFiles is the list of default values used in the | |||
| // python_ignore_files option. | |||
| var defaultIgnoreFiles = map[string]struct{}{ | |||
| } | |||
| var defaultIgnoreFiles = map[string]struct{}{} | |||
There was a problem hiding this comment.
The precommit seems to be doing this? 🤷
aignas
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just fixes a crash when
generation_mode: update_onlycausesGenerateRulesto not be invoked for 100% of directories.Fix #2707