Skip to content

chore: remove semantics.bzl #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Apr 1, 2025

semantics.bzl is an artifact of how the rules avoided patching when they were part of Bazel.
With the code moved out of Bazel, such helper files aren't necessary anymore.

Work towards #2522

@rickeylev rickeylev requested a review from aignas as a code owner April 1, 2025 08:39
@rickeylev rickeylev changed the title Chore.rm.semantics chore: remove semantics.bzl Apr 1, 2025
@rickeylev rickeylev enabled auto-merge April 1, 2025 08:40
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickeylev rickeylev added this pull request to the merge queue Apr 1, 2025
Merged via the queue into bazel-contrib:main with commit 24b9c51 Apr 1, 2025
3 checks passed
@rickeylev rickeylev deleted the chore.rm.semantics branch April 1, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants